Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#4530 closed enhancement (fixed)

Add "Watched" Filter Option to the Watch Recordings Screen

Reported by: Donald R. Huettl <drhuettl@…> Owned by: stuartm
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The attached patch adds an "Unwatched" option to the list of group filters in the Watch Recordings screen.

Attachments (3)

filter_watched.patch (27.6 KB) - added by Donald R. Huettl <drhuettl@…> 12 years ago.
filter_watched_0.10.patch (27.9 KB) - added by Donald R. Huettl <drhuettl@…> 12 years ago.
watched_filter.diff (3.4 KB) - added by cpinkham 12 years ago.
Add a 'Show Watched Programs' filter to the Group View popup.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by Donald R. Huettl <drhuettl@…>

Attachment: filter_watched.patch added

Changed 12 years ago by Donald R. Huettl <drhuettl@…>

Attachment: filter_watched_0.10.patch added

comment:1 Changed 12 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham
Status: newassigned

I'm still not sure if I'd prefer this done this way or via a filter on the view popup. Can you take a look at the watched_filter.diff file I'm attaching and see what you think about how it is implemented. By default, watched files won't be displayed, you'll have to turn them on via the popup "Change Group View" set of checkboxes. If I were to put this into SVN, there would be a database update to go along with it to display the watched files by default unless the user turned them off.

Changed 12 years ago by cpinkham

Attachment: watched_filter.diff added

Add a 'Show Watched Programs' filter to the Group View popup.

comment:2 Changed 12 years ago by Donald R. Huettl <drhuettl@…>

Your patch works well, and seems like it's a little more concise. Only thing I might miss from my version is a some indication that watched recordings are not being included.

comment:3 Changed 12 years ago by cpinkham

Milestone: unknown0.21

Want to put something like this in before 0.21, but am not sure if I'll get the visual indication part.

comment:4 Changed 12 years ago by cpinkham

Milestone: 0.210.22

comment:5 Changed 11 years ago by stuartm

Owner: changed from cpinkham to stuartm
Status: assignedaccepted

comment:6 Changed 10 years ago by stuartm

Status: acceptedstarted

comment:7 Changed 10 years ago by stuartm

Resolution: fixed
Status: startedclosed

(In [20909]) Add an option to filter watched recordings from the Watch Recordings screen. Patch by Chris Pinkham, closes #4530. N.B. You may need to enable the option to maintain existing behaviour.

comment:8 Changed 10 years ago by stuartm

(In [20911]) Change the default for the watched filter added in [20909]. Refs #4530

comment:9 Changed 10 years ago by stuartm

(In [20912]) Sorry, missed a file in [20909]. Refs #4530

Note: See TracTickets for help on using tickets.