Opened 11 years ago

Closed 11 years ago

#4588 closed patch (fixed)

Move StorageGroup to libmyth

Reported by: sphery <mtdean@…> Owned by: cpinkham
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch, mythtv-move_storagegroup_to_libmyth.patch makes no functional changes to mythtv; it simply moves libs/libmythtv/storagegroup.{h,cpp} to libs/libmyth/storagegroup.{h,cpp}. Since StorageGroups? will be used by plugins and since some libmyth code (i.e. the code for doing database backups) will be using StorageGroups?, it makes sense for StorageGroup? to be moved to libmyth.

Note that the patch "includes" an svn rm libs/libmythtv/storagegroup.{h,cpp} and svn add libs/libmyth/storagegroup.{h,cpp} (when using svn move, the "added" file wouldn't show up in the diff), which should work, but is proabably worth verifying in your local tree before committing. This accounts for almost all of the "changes" to the code (and the vast majority of the size of the patch. I've also included a copy "-no_svn_remove_add" which does not move the files (in case you'd prefer to use svn move to move them yourself after applying the patch).

The patch also fixes references to the header in #include's throughout mythtv. This is why the patch touches so many files.

Also, the patch now installs the storagegroup.h header since StorageGroups? will be used in plugins. Before this patch, the header was not installed.

This probably requires a make distclean.

Attachments (2)

mythtv-move_storagegroup_to_libmyth.patch (56.7 KB) - added by sphery <mtdean@…> 11 years ago.
mythtv-move_storagegroup_to_libmyth-no_svn_remove_add.patch (4.1 KB) - added by sphery <mtdean@…> 11 years ago.
Same patch but does not svn rm/svn add the storagegroup.{h,cpp} files

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by sphery <mtdean@…>

Changed 11 years ago by sphery <mtdean@…>

Same patch but does not svn rm/svn add the storagegroup.{h,cpp} files

comment:1 Changed 11 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham
Status: newassigned

comment:2 Changed 11 years ago by cpinkham

Milestone: unknown0.21

comment:3 Changed 11 years ago by cpinkham

Resolution: fixed
Status: assignedclosed

(In [15834]) Move the StorageGroup? class from libmythtv to libmyth.

Closes #4588 using patch by Michael T. Dean.

Note: See TracTickets for help on using tickets.