Opened 12 years ago

Closed 12 years ago

#4615 closed patch (fixed)

Create video, audio, subtitle properties columns in the program table

Reported by: Janne Grunau Owned by: Janne Grunau
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

[13952] introduced audio and video properties and subtitle type bit fields. It reused for schema backwards compatibility the hdtv, stereo and closecaptioned columns.

Attached patch adds the columns audioprop, videoprop and subtitletypes to the program and recorded program tables, move the old values to the new columns and updates the code to use only the new columns.

It would be nice if someone using schedules direct can test the patch

Attachments (1)

property_flags_v2.diff (15.8 KB) - added by Janne Grunau 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Janne Grunau

Attachment: property_flags_v2.diff added

comment:1 Changed 12 years ago by bjm

It appear that this will populat the existing bool columns and the new property bitfields properly for the DataDirect? grabber.

Current svn with DD grab:

mysql> select stereo,hdtv,closecaptioned as cc,subtitled as sub, title from program where stereo and hdtv and closecaptioned and subtitled;
+--------+------+----+-----+----------------------+
| stereo | hdtv | cc | sub | title                |
+--------+------+----+-----+----------------------+
|      1 |    1 |  1 |   1 | Maria Full of Grace  |
|      1 |    1 |  1 |   1 | The Science of Sleep |
|      1 |    1 |  1 |   1 | Maria Full of Grace  |
|      1 |    1 |  1 |   1 | The Science of Sleep |
+--------+------+----+-----+----------------------+

Truncated 'program' then grabbed with SVN + property_flags_v2.diff:

mysql> select stereo,hdtv,closecaptioned as cc,subtitled as sub, title,audiopropd hdtv and closecaptioned and subtitled;
+--------+------+----+-----+----------------------+----+----+----+
| stereo | hdtv | cc | sub | title                | ap | sp | vp |
+--------+------+----+-----+----------------------+----+----+----+
|      1 |    1 |  1 |   1 | Maria Full of Grace  |  1 |  3 |  1 |
|      1 |    1 |  1 |   1 | The Science of Sleep |  1 |  3 |  1 |
|      1 |    1 |  1 |   1 | Maria Full of Grace  |  1 |  3 |  1 |
|      1 |    1 |  1 |   1 | The Science of Sleep |  1 |  3 |  1 |
+--------+------+----+-----+----------------------+----+----+----+

comment:2 Changed 12 years ago by Janne Grunau

Status: newaccepted

comment:3 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: acceptedclosed

(In [15900]) Add columns for audio and video properties to program and recordedprogram tables

don't change the meaning of the hdtv, stereo, closecaptioned and subtitled columns. Both old and new columns are updated. Fixes #4615.

Note: See TracTickets for help on using tickets.