Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4622 closed patch (wontfix)

Zero Copy mpegstreamhandler and dtvrecorders

Reported by: bradley.kite@… Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch reduces the amount of in-memory copying of TSPackets that occurs by passing pointers instead of copying 188+ bytes of data on the stack between function calls.

Attachments (1)

zero_copy_mpeg_streams.diff​ (19.9 KB) - added by bradley.kite@… 12 years ago.
Reduces copying of tspackets on the stack.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by bradley.kite@…

Attachment: zero_copy_mpeg_streams.diff​ added

Reduces copying of tspackets on the stack.

comment:1 Changed 12 years ago by danielk

Milestone: unknown → 0.22
Owner: changed from Isaac Richards to danielk
Status: new → assigned
Version: unknown → head

Since this may add instability I'm pushing it off to just after the 0.21 branch is created..

comment:2 Changed 12 years ago by danielk

Resolution: → wontfix
Status: assigned → closed

Bradley, this patch doesn't really do anything. In C++ a reference "&" is basically just a pointer "*" with some some additional safety checks. It won't actually trigger any memory copies.

comment:3 Changed 12 years ago by bradley.kite@…

Ahh :-)

Thanks - I dont know C++ that well (as you may have been able to tell :-p)

Note: See TracTickets for help on using tickets.