Opened 12 years ago

Closed 12 years ago

#4657 closed patch (fixed)

dvdnav needs to drop locks when it fails

Reported by: Erik Hovland <erik@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

In libmythdvdnav, in the files dvdnav.c and searching.c there are a few error conditions where the thread lock is not dropped even though the function is going down the fail code path.

Since it is likely that the program will bow out in these paths, it isn't a big deal. But it is a good idea to give up any locks you might have when you don't need them.

Attachments (1)

dvdnav-lock-fixing.patch (1.8 KB) - added by Erik Hovland <erik@…> 12 years ago.
Fixes lack of lock release in failure paths

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Erik Hovland <erik@…>

Attachment: dvdnav-lock-fixing.patch added

Fixes lack of lock release in failure paths

comment:1 Changed 12 years ago by Janne Grunau

Owner: changed from Isaac Richards to Janne Grunau
Status: newaccepted

comment:2 Changed 12 years ago by Janne Grunau

(In [15989]) Release mutexes on errors in libdvdnav

From: Erik Hovland <erik[a]hovland[p]org> Refs #4657

comment:3 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: acceptedclosed

Fixed by [15991]

Note: See TracTickets for help on using tickets.