Opened 16 years ago
Closed 16 years ago
#4661 closed patch (fixed)
inputid should be signed or conditional is bogus
Reported by: | Owned by: | Janne Grunau | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
In dvbchannel.cpp the variable inputid is unsigned. But the conditional tests for less then zero. Which will be impossible and the code path will never happen. Since the function that is called can return a signed value it is better to make inputid signed so the test works.
Attachments (1)
Change History (4)
Changed 16 years ago by
Attachment: | inputid-should-be-signed.patch added |
---|
comment:1 Changed 16 years ago by
Owner: | changed from Isaac Richards to Janne Grunau |
---|---|
Status: | new → accepted |
comment:2 Changed 16 years ago by
Note: See
TracTickets for help on using
tickets.
Changes the inputid variable to a signed type