Opened 12 years ago

Closed 12 years ago

#4661 closed patch (fixed)

inputid should be signed or conditional is bogus

Reported by: Erik Hovland <erik@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

In dvbchannel.cpp the variable inputid is unsigned. But the conditional tests for less then zero. Which will be impossible and the code path will never happen. Since the function that is called can return a signed value it is better to make inputid signed so the test works.

Attachments (1)

inputid-should-be-signed.patch (894 bytes) - added by Erik Hovland <erik@…> 12 years ago.
Changes the inputid variable to a signed type

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Erik Hovland <erik@…>

Changes the inputid variable to a signed type

comment:1 Changed 12 years ago by Janne Grunau

Owner: changed from Isaac Richards to Janne Grunau
Status: newaccepted

comment:2 Changed 12 years ago by Janne Grunau

(In [15997]) Fix check for invalid inputid in DVBChannel::Tune(DTVMultiplex, QString)

From: Erik Hovland <erik[a]hovland[p]org> Refs #4661

comment:3 Changed 12 years ago by Janne Grunau

Resolution: fixed
Status: acceptedclosed

(In [15999]) Fix check for invalid inputid in DVBChannel::Tune(DTVMultiplex, QString)

From: Erik Hovland <erik[a]hovland[p]org> Merges [15997] from trunk. Fixes #4661

Note: See TracTickets for help on using tickets.