Opened 16 years ago
Closed 16 years ago
#4673 closed patch (invalid)
Fix for my previous fixup for TV::IsTunable()
Reported by: | Owned by: | Janne Grunau | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | unknown |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The fix I submitted in [15565] is suboptimal and results queries of the current card that is on the excluded_cards list. Which is unnecessary extra work.
I think the attached patch is better since it only includes the current card if needed.
Attachments (2)
Change History (5)
Changed 16 years ago by
Attachment: | mythtv_IsTunable_need_one_card.diff added |
---|
comment:1 Changed 16 years ago by
Heh, updated patch. There is no point checking the current card's inputs if it's on the excluded cards list.
comment:2 Changed 16 years ago by
Milestone: | unknown → 0.21 |
---|---|
Owner: | changed from Isaac Richards to Janne Grunau |
Status: | new → accepted |
comment:3 Changed 16 years ago by
Resolution: | → invalid |
---|---|
Status: | accepted → closed |
As far as I can see the current code is correct. We have to check for free inputs the current card. If the input group is busy recording something, only channels on the same input should be marked as tuneable.
The second patch would mark all channels tuneable even if they are on a source not connected to the current card.
IsTunable?() need at least one card