Opened 11 years ago

Closed 11 years ago

#4673 closed patch (invalid)

Fix for my previous fixup for TV::IsTunable()

Reported by: Shane Shrybman <gnome42@…> Owned by: Janne Grunau
Priority: minor Milestone: 0.21
Component: mythtv Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

The fix I submitted in [15565] is suboptimal and results queries of the current card that is on the excluded_cards list. Which is unnecessary extra work.

I think the attached patch is better since it only includes the current card if needed.

Attachments (2)

mythtv_IsTunable_need_one_card.diff (734 bytes) - added by Shane Shrybman <gnome42@…> 11 years ago.
IsTunable?() need at least one card
mythtv_IsTunable_need_one_card2.diff (836 bytes) - added by Shane Shrybman <gnome42@…> 11 years ago.
Update

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Shane Shrybman <gnome42@…>

IsTunable?() need at least one card

Changed 11 years ago by Shane Shrybman <gnome42@…>

Update

comment:1 Changed 11 years ago by Shane Shrybman <gnome42@…>

Heh, updated patch. There is no point checking the current card's inputs if it's on the excluded cards list.

comment:2 Changed 11 years ago by Janne Grunau

Milestone: unknown0.21
Owner: changed from Isaac Richards to Janne Grunau
Status: newaccepted

comment:3 Changed 11 years ago by Janne Grunau

Resolution: invalid
Status: acceptedclosed

As far as I can see the current code is correct. We have to check for free inputs the current card. If the input group is busy recording something, only channels on the same input should be marked as tuneable.

The second patch would mark all channels tuneable even if they are on a source not connected to the current card.

Note: See TracTickets for help on using tickets.