Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#4712 closed enhancement (fixed)

Improve UPnP Disable test and warning.

Reported by: Roo <roo.watt@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.21
Component: mythtv Version: head
Severity: medium Keywords: localhost loopback upnp disable
Cc: Ticket locked: no

Description

Modify test of sIP to include 127.0.0.1/8 as per rfc3330.

Also reword the log message when UPnP is disabled, IMHO it isn't really an error.

Attachments (2)

upnp_loopback_warning.diff​ (674 bytes) - added by Roo <roo.watt@…> 16 years ago.
upnp_loopback_warning2.diff​ (670 bytes) - added by mythtv@… 16 years ago.
/8 means the first 8 bits are fixed, so bits 9 to 24 does not need to be 0

Download all attachments as: .zip

Change History (5)

Changed 16 years ago by Roo <roo.watt@…>

Attachment: upnp_loopback_warning.diff​ added

Changed 16 years ago by mythtv@…

Attachment: upnp_loopback_warning2.diff​ added

/8 means the first 8 bits are fixed, so bits 9 to 24 does not need to be 0

comment:1 Changed 16 years ago by Isaac Richards

Resolution: → fixed
Status: new → closed

(In [16353]) Apply patch from #4712 to 'improve upnp disable test and warning message'.

Fixes #4712.

comment:2 Changed 16 years ago by Isaac Richards

(In [16365]) Merge r16353 from trunk:

Apply patch from #4712 to 'improve upnp disable test and warning message'. Fixes #4712.

comment:3 Changed 16 years ago by anonymous

The 172.16/12 subnet (172.16.0.0 – 172.31.255.255) are not necessarily loopback addresses as it is an IANA assigned private IP space. (RFC1700/RFC3300) Perhaps UPnP should still be enabled in this range?

Note: See TracTickets for help on using tickets.