Opened 19 years ago
Closed 19 years ago
#474 closed patch (fixed)
Initial filter in watch recordings broken
Reported by: | Owned by: | cpinkham | |
---|---|---|---|
Priority: | minor | Milestone: | 0.19 |
Component: | mythtv | Version: | head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Looks like [7358] broke the initial filter for watch recordings. cancelPopup cannot be called when displaying the initial filter because there isn't a popup to be canceled which is contrary to the typical behavior when displaying this box because it is normally called from another popup. This patch fixes.
Index: programs/mythfrontend/playbackbox.cpp =================================================================== --- programs/mythfrontend/playbackbox.cpp (revision 7485) +++ programs/mythfrontend/playbackbox.cpp (working copy) @@ -3777,11 +3708,12 @@ void PlaybackBox::showRecGroupChooser(void) { - if (!expectingPopup) - return; + // This is contrary to other code because the option to display this + // box when starting the Playbackbox means expectingPopup will not be + // set, nor is there a popup to be canceled as is normally the case + if (expectingPopup) + cancelPopup(); - cancelPopup(); - initRecGroupPopup(tr("Select Group Filter"), "showRecGroupChooser"); QStringList groups;
Note: See
TracTickets for help on using
tickets.
(In [7486]) Patch by Kevin Kuphal to fix the initial filter popup on the watch recordings screen that I broke in [7358]. :( Closes #474.