Opened 16 years ago
Closed 16 years ago
#4744 closed defect (fixed)
null pointer check comes too late in MediaMonitorUnix::AddDevice
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | minor | Milestone: | 0.21 |
Component: | mythtv | Version: | head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
In MediaMonitorUnix::AddDevice? in libs/libmyth/mediamonitor-unix.cpp there is a check to make sure that the fstab struct pointer it was handed is not null. But the check comes after the pointer was dereferenced.
Attachments (1)
Change History (2)
Changed 16 years ago by
Attachment: | libs_libmyth_mediamonitor-unix.cpp-fix-null-check-too-late.patch added |
---|
comment:1 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [16208]) Fixes #4744. Moves a null pointer check to a slightly earlier point in MediaMonitorUnix::AddDevice?() so we don't try to dereference it before NULL check (looks like it was moved to a bad location for a now commented out debug statement..)
Note: See
TracTickets for help on using
tickets.
Moves the check for null pointer before the pointer is dereferenced