Conflict resolution menu does not include Never Record option

[Nick Morrott <knowledgejunkie(at)gmail(dot)com>]

When using the recording conflict resolution menu (on the Upcoming Recordings listings for example) the option to 'Never Record' a programme is seemingly not made available (on r14770).

This means that it is not possible to forcibly flag a recording (that just so happens to be conflicting) to never record, which is possible for all other non-conflicting scheduled recordings, duplicate-detection allowing.

[Nick Morrott <knowledgejunkie (at) gmail (dot) com>]

The behaviour I was seeing when the ticket was reported was likely due to the conflicting programme's duplicate detection method and possible omission of a subtitle.

Current trunk (tested with r20931) *does* display the Don't Record/Never? Record options for conflicting entries in the upcomings list, so this ticket can be closed.

[paulh]

Closing at submitters request

[Nick Morrott <knowledgejunkie (at) gmail (dot) com>]

Taking a closer look in current trunk, I have a query before this ticket is closed or investigated further:

===== When *exactly* should the Never Record option be displayed on the menu? Should it only be displayed when the selected dupe detection method will work for the current programme? =====

I've been experimenting with a record rule for a show "Medical Detectives" that gets listings via EIT on DVB-S. There are no program subtitles available, only descriptions. I set this rule up (anytime on channel) to purposefully conflict with another recording to test the initial reason for this ticket.

With Subtitle & Description dupe matching:

No dupes are found/marked due to the missing subtitles in the listings and the selected dupe detection (as expected). However, the entries marked as conflicting, and earlier/later unconflicting entries all include a "Never record" option on their menus, even though it does nothing due to the dupe detection method. In the future it would do something if another rule matching the title was created, or the current rule was amended.

With Subtitle then Description dupe matching:

With blank subtitles but good descriptions, the dupe detection works as expected and the scheduler can move the conflicting showings to a later time. However, the entries marked later (and guessing any earlier entries too) do not include a "Never record" option on their schedule menu, whilst the bumped copies of those entries do. Here I think that they should all have the option so that a user can use any of the entries (earlier, later or the entry that will record) to add a 'fake' recorded entry into oldrecorded.

With subtitle dupe matching:

None of the upcoming recordings matching the title have a "Never Record" entry on their menu (as would be expected).

With description dupe matching:

*ALL* entries have Never Record entries, even those flagged as record later (contrast this with sub-then-desc above)

With no dupe matching:

Again, none of the upcoming recordings matching the title have a "Never Record" entry on their menu (as would be expected).

[stuartm]

Pushing this to 0.23, it's not a major bug if it's even a bug at all.

[stuartm]

David, maybe you can clarify when 'Never Record' isn't shown.

[gigem]

(In [23246]) Added a test for the subtitle-then-description dupe check case when determining whether or not to show the never record option for non-recording programs. Also added a little indentation to try to make things a little easier to read and comprehend.

Refs #4795.

[gigem]

The subtitle-then-description case wasn't being handled. I added it, but that code is so dense I'm not positive it truly fixes the problem. I'd appreciate it if Nick would recheck this.