Opened 12 years ago

Closed 12 years ago

#4826 closed defect (invalid)

remove useless check of mytcontextprivate pointer 'd'

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.21
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

In ticket 4745, Isaac correctly pointed out that it is impossible for a mythcontext object to have a null pointer d since d is new'ed in the constructor (and it would exception out if the new didn't work). That means that the checks for 'd' being a null pointer in MythContext::GetSetting?() are useless and should be removed before they confuse anybody.

Attachments (1)

libs_libmyth_mythcontext.cpp-d-check-is-useless.patch (1.2 KB) - added by Erik Hovland <erik@…> 12 years ago.
removes useless d null pointer checks

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by Erik Hovland <erik@…>

removes useless d null pointer checks

comment:1 Changed 12 years ago by Isaac Richards

Resolution: invalid
Status: newclosed

This was already done in trunk, and doesn't need to be in the branch.

Note: See TracTickets for help on using tickets.