Opened 12 years ago

Closed 12 years ago

#4827 closed defect (fixed)

data pointer variable never used

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

In QCodecs::quotedPrintableDecode(), the data pointer variable is never used. And the call to get it does no work except hand over the pointer. It should be removed.

Attachments (1)

libs_libmyth_qmdcodec.cpp-remove-unused-pointer-variable.patch (646 bytes) - added by Erik Hovland <erik@…> 12 years ago.
removes pointer variable data and calls related to it

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Erik Hovland <erik@…>

removes pointer variable data and calls related to it

comment:1 Changed 12 years ago by Isaac Richards

Milestone: 0.210.22

comment:2 Changed 12 years ago by Nigel

A better change would be to actually use data[i] instead of in.at(i), but there might be character encoding issues - needs testing.

comment:3 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [17541]) Fixes #4827. Gets rid of unused variable + it's init.

Note: See TracTickets for help on using tickets.