Opened 15 years ago
Closed 15 years ago
#483 closed patch (fixed)
PATCH: enable openGL for mythplugins Mac OS X
Reported by: | Owned by: | Nigel | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythgallery | Version: | head |
Severity: | medium | Keywords: | mac opengl mythgallery |
Cc: | Ticket locked: | no |
Description (last modified by )
Mac OS X includes openGL in all installations so we should allow enabling of openGL on the mac even if we don't detect libGL. (it will never find it) I tested this with mythgallery and should also work fine for mythmusic once I finally get it to compile all the way. OpenGL vsync uses x11 specific extensions so we still can't use that. This patch modifies configure to allow the user to use --enable-opengl when configuring the plugins.
Attachments (1)
Change History (11)
Changed 15 years ago by
Attachment: | enablePluginOpenGLMac.patch added |
---|
comment:1 Changed 15 years ago by
I saw a bunch of other patches get applied to the configure script, just making sure this one didn't get lost
comment:2 Changed 15 years ago by
Owner: | changed from Isaac Richards to Nigel |
---|
Nigel takes care of the Mac OSX port. The other ./configuration changes didn't require any runtime testing so I could commit them safely...
comment:3 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:4 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Sorry, accidentally closed this instead of #482.
comment:5 Changed 15 years ago by
Geoff, applied the change locally, but there seem to be lots of compile errors in the MythGallery OpenGL code?
c++ -c -pipe -Wall -W -fomit-frame-pointer -DPIC -fPIC -D_GNU_SOURCE -DPREFIX=\"\" -D_FILE_OFFSET_BITS=64 -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -DQT_PLUGIN -DQT_SHARED -DQT_ACCESSIBILITY_SUPPORT -DQT_TABLET_SUPPORT -I/Volumes/Backups/qt/mkspecs/default -I. -I/include -I/usr/kde/3.3/include -I/include -I/Volumes/Backups/qt/include -I/System/Library/Frameworks/OpenGL.framework/Versions/A/Headers -I/System/Library/Frameworks/AGL.framework/Versions/A/Headers -o glsingleview.o glsingleview.cpp glsingleview.cpp: In member function `virtual void GLSingleView::paintGL()': glsingleview.cpp:216: error: `myth_system' undeclared (first use this function) glsingleview.cpp:216: error: (Each undeclared identifier is reported only once
for each function it appears in.)
glsingleview.cpp: In member function `void GLSingleView::createTexInfo()': glsingleview.cpp:1397: error: variable `QPainter p' has initializer but
incomplete type
make: * [glsingleview.o] Error 1
Do you have local patches for these?
comment:6 Changed 15 years ago by
I don't have a patch, this is a "works for me" situation. What version of os x are you running. It compiles and runs for me without a problem on 10.4.2 and 10.4.3. Check out the .dmg I have at http://willamette.edu/~gkruse/myth/ The newest one was compiled with OpenGl? enabled.
comment:7 Changed 15 years ago by
Description: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
I was stupid (didn't have the latest gallery source). Your patch works. I am about to check in a slightly cleaner one, though.
comment:8 Changed 15 years ago by
(In [7875]) OS X fixes #483 and #576. Search for headers based on library paths, and force OpenGL for MythGallery on Darwin/OS X
comment:9 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Do'h - should have tested more thoroughly (like deleted Makefiles before running configure). OK, so it looks like opengl=yes does the same as opengl=detect, which doesn the same as opengl=blah. All of these try to detect the library. I think a patch to configure is in order, but I will have a browse through its history (and mythtv's) to see if there is any good reason for it being, um, broken?
comment:10 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
After some discussion with the other devs, having everything always detect is the intended behaviour. So I have added an explicit check for the AGL Framework. I think the pathname /System/Library/Frameworks?/AGL.framework/Versions/A/AGL is unique enough that it will only be found on OS X :-)
the patch described in the ticket