Opened 13 years ago
Closed 13 years ago
Last modified 13 years ago
#4831 closed defect (fixed)
explicit default ctor is useless
Reported by: | Owned by: | danielk | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | mythtv | Version: | 0.21-fixes |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The classes LCDMenuItem and LCDTextItem both have explicit declarations of default ctors. Since they also have member variables and these explicit declarations do not initialize them, they are considered dangerous since they can be used to make uninitialized objects. They should be removed.
Attachments (1)
Change History (6)
Changed 13 years ago by
Attachment: | libs_libmyth_lcddevice.h-remove-default-ctor.patch added |
---|
comment:1 Changed 13 years ago by
Milestone: | 0.21 → 0.22 |
---|
comment:2 Changed 13 years ago by
Owner: | changed from Isaac Richards to danielk |
---|---|
Status: | new → assigned |
comment:3 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:4 Changed 13 years ago by
Oops. Sorry Daniel. I didn't see that you had taken ownership of this one.
comment:5 Changed 13 years ago by
Heh, dangerous was too strong of a word to use. Sorry. I was just saying that any user of the class who instantiated an object using that ctor would not get a ready to go object. And they might not know it since there would be no warning that that was the case. I'll try to tone down the rhetoric in future patches.
removes default ctors that might be used inappropriately