Opened 14 years ago

Closed 14 years ago

#484 closed defect (fixed)

mythplugins configure bug

Reported by: gkruse@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythgallery Version: head
Severity: medium Keywords: mythplugins configure mac
Cc: Ticket locked: no

Description

The configure script for mythplugins assumes that pkg-config is available which it is not by default on all platforms. This is true on Mac OS X and breaks exif support for mythgallery if libexif > 0.6.9 is used. Is there an alternate way to test for the version of libexif that is not dependent on pkg-config? A platform independent way to determine the lib version would be the best fix. pkg-config is used on line 655 in the configure script.

Attachments (1)

configure_libexif.patch (1.3 KB) - added by gkruse@… 14 years ago.
--use-new-libexif configure patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by anonymous

Component: mythtvmythgallery

comment:2 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7526]) Closes #484 by testing for pkg-config before trying to use it.

If it is not present, we print a warning about not being able to determine the version of libexif.

comment:3 Changed 14 years ago by gkruse@…

Resolution: fixed
Status: closedreopened

I have come up with (in my opinion) a more elegant fix to this problem. I have added --use-new-libexif as a configure option so that people don't have to add defines to header files manually. This version still prints out a warning if pkg-config is not found and --use-new-libexif is not specified. Please see the attached patch and let me know if I need to make any changes. I prefer using this version of the fix because when using automated build scripts (such as osx-packager.pl) it is much easier to specify a configure option. If / when this patch is accepted, I have a corresponding patch for osx-packager.pl

Changed 14 years ago by gkruse@…

Attachment: configure_libexif.patch added

--use-new-libexif configure patch

comment:4 Changed 14 years ago by anonymous

This may be better, but I'd prefer if you found a way to detect the package version without using pkg-config. Even if it is just by trying whatever OS X uses for version management.

comment:5 Changed 14 years ago by danielk

Resolution: fixed
Status: reopenedclosed

(In [7584]) Closes #484, by applying patch.

I renamed "--use-new-libexif" in the patch to "--enable-new-exif".

Note: See TracTickets for help on using tickets.