Opened 12 years ago

Closed 12 years ago

#4846 closed defect (fixed)

assert is useless in FIRFilter::evaluate()

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

In FIRFilter::evaluate(), there is an assert call: 

    assert(resultDivFactor >= 0);

But resultDivFactor is an unsigned type. So it will never be less then zero.

Attachments (1)

libs_libmythsoundtouch_FIRFilter.cpp-remove-unnecessary-assert.patch​ (746 bytes) - added by Erik Hovland <erik@…> 12 years ago.
removes useless assert

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythsoundtouch_FIRFilter.cpp-remove-unnecessary-assert.patch​ added

removes useless assert

comment:1 Changed 12 years ago by Isaac Richards

Milestone: 0.21 → 0.22

comment:2 Changed 12 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [17204]) Fixes #4846. Removes an unnecessary assert.

Note: See TracTickets for help on using tickets.