Opened 13 years ago
Closed 13 years ago
#4847 closed defect (fixed)
RateTransposer::isEmpty() does not overrride FIFOSamplePipe::isEmpty()
Reported by: | Owned by: | Isaac Richards | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | mythtv | Version: | 0.21-fixes |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
The declaration and implementation signature of RateTransposer::isEmpty() does not match that of the abstract class's FIFOSamplePipe::isEmpty(). Which means that the compiler will not properly override FIFOProcessor's isEmpty() with RateTransposer?'s in the inheritance graph. This can lead to weird behavior since callers will expect to get the right member function when calling it.
Attachments (1)
Change History (3)
Changed 13 years ago by
Attachment: | libs_libmythsoundtouch_RateTransposer.h-bad-override-of-isEmpty.patch added |
---|
comment:1 Changed 13 years ago by
Milestone: | 0.21 → 0.22 |
---|
Note: See
TracTickets for help on using
tickets.
corrects the signature of RateTransposer::isEmpty() so it matches abstract class's isEmpty()