Opened 13 years ago

Closed 13 years ago

#4847 closed defect (fixed)

RateTransposer::isEmpty() does not overrride FIFOSamplePipe::isEmpty()

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

The declaration and implementation signature of RateTransposer::isEmpty() does not match that of the abstract class's FIFOSamplePipe::isEmpty(). Which means that the compiler will not properly override FIFOProcessor's isEmpty() with RateTransposer?'s in the inheritance graph. This can lead to weird behavior since callers will expect to get the right member function when calling it.

Attachments (1)

libs_libmythsoundtouch_RateTransposer.h-bad-override-of-isEmpty.patch​ (1.0 KB) - added by Erik Hovland <erik@…> 13 years ago.
corrects the signature of RateTransposer::isEmpty() so it matches abstract class's isEmpty()

Download all attachments as: .zip

Change History (3)

Changed 13 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythsoundtouch_RateTransposer.h-bad-override-of-isEmpty.patch​ added

corrects the signature of RateTransposer::isEmpty() so it matches abstract class's isEmpty()

comment:1 Changed 13 years ago by Isaac Richards

Milestone: 0.21 → 0.22

comment:2 Changed 13 years ago by Nigel

Resolution: → fixed
Status: new → closed

(In [16358]) Change isEmpty() signature, fix inheritance. Patch by Erik Hovland. Closes #4847

Note: See TracTickets for help on using tickets.