Opened 12 years ago

Closed 12 years ago

#4848 closed defect (fixed)

remove useless null check of chanInfo

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: mythtv Version: 0.21-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

In Scheduler::AddNotListed?, the for loop checks after it is dereferenced. Since it is just about guaranteed that p is valid already the check is useless.

Attachments (1)

programs_mythbackend_scheduler.cpp-fix-null-check-too-late.patch​ (561 bytes) - added by Erik Hovland <erik@…> 12 years ago.
remove useless null check of p

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Erik Hovland <erik@…>

Attachment: programs_mythbackend_scheduler.cpp-fix-null-check-too-late.patch​ added

remove useless null check of p

comment:1 Changed 12 years ago by Erik Hovland <erik@…>

The reference to chanInfo in the summary is bogus. I confused it with my next patch. The check is for pointer p.

comment:2 Changed 12 years ago by Isaac Richards

Milestone: 0.21 → 0.22

comment:3 Changed 12 years ago by Nigel

Resolution: → fixed
Status: new → closed

(In [16354]) Remove useless null check. Closes #4848 - patch by Erik Hovland

Note: See TracTickets for help on using tickets.