Opened 16 years ago

Closed 16 years ago

#4851 closed patch (fixed)

MythPhone fix for loopback test mode

Reported by: Shane Shrybman <gnome42@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythphone Version: unknown
Severity: low Keywords:
Cc: Ticket locked: no

Description

The loopback test mode in mythphone is no longer working.

The avcodec_encode_video(..) call was returning -1. This was due to the pictureOut AVFrame not being initialized correctly. Specifically the pts was not initialized correctly.

The fix in the attached patch switches pictureOut to be a pointer to AVFrame and then uses avcodec_alloc_frame() to allocate and correctly initialize all the fields including pts.

I suspect this bug was revealed by one of the ffmpeg sync ups.

Attachments (2)

mythphone_loopback_fix.diff​ (2.3 KB) - added by Shane Shrybman <gnome42@…> 16 years ago.
mythphone_loopback_fix_v2.diff​ (576 bytes) - added by Shane Shrybman <gnome42@…> 16 years ago.
v2

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by Shane Shrybman <gnome42@…>

Attachment: mythphone_loopback_fix.diff​ added

comment:1 Changed 16 years ago by Shane Shrybman <gnome42@…>

Updated patch v2.

Calling avcodec_get_frame_defaults() to initialize pictureOut.pts is a simpler fix for the problem.

Changed 16 years ago by Shane Shrybman <gnome42@…>

Attachment: mythphone_loopback_fix_v2.diff​ added

v2

comment:2 Changed 16 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [16463]) Fixes #4851. Low impact fix from Shane for mythphone loop back support.

Note: See TracTickets for help on using tickets.