Opened 13 years ago

Closed 12 years ago

#4870 closed defect (fixed)

Incorrect Aspect Ratio

Reported by: greg Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: Video Playback Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by stuartm)

When first starting playback of the test.avi video referenced in #4567 we incorrectly set the aspect ratio to 2. Later(even just 1 second later) if we for example seek back to the start of the video it is corrected, as well after a few seconds of playback we eventually get the right aspect and correct accordingly.

From what I can see when we first call AvFormatDecoder::InitVideoCodec?() enc->sample_aspect_ratio has no value and we end up defaulting to just a single width/height for the aspect.

But after a few frames have been decoded or, the next time AvFormatDecoder::H264PreProcessPkt gets called the sample_aspect_ratio is set so we can then properly calculate the aspect.

I've tested this with other players and they don't seem to have the same problem.

Change History (3)

comment:1 Changed 13 years ago by stuartm

Component: mythtvVideo Playback
Description: modified (diff)
Version: unknownhead

comment:2 Changed 12 years ago by robertm

This should be fixed by r21308, but the sample is no longer available. OK to close?

comment:3 Changed 12 years ago by stuartm

Resolution: fixed
Status: newclosed

Fixed according to Greg.

Note: See TracTickets for help on using tickets.