Opened 12 years ago

Closed 12 years ago

#4874 closed patch (duplicate)

win32 - default MYTHCONFDIR for windows

Reported by: arnonm@… Owned by: Nigel
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords: win32
Cc: Ticket locked: yes

Description

Allows default MYTHCONFDIR to be win32 path

Attachments (1)

mythcontext.patch4 (1.2 KB) - added by anonymous 12 years ago.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by anonymous

Attachment: mythcontext.patch4 added

comment:1 Changed 12 years ago by Isaac Richards

Milestone: 0.210.22

comment:2 Changed 12 years ago by Nigel

Status: newinfoneeded_new
Type: enhancementpatch
  1. MYTHCONFDIR was already corrected by an earlier patch, #4612. This patch seems to have nothing to do with that env. variable?
  1. The patch adds a new variable, MYTHLIBDIR. If we are going to add that, then it should be for both Unix and Win32.
  1. I don't understand why using the compiled-in LIBDIR isn't good enough. win32-packager.pl sets PREFIX to /usr/lib, but if you have a different location for your installed libs on the PC, configure differently. (e.g. configure --prefix=/c/Program Files/MythTV)

Rejecting until there is some explanation of the actual problem

comment:3 Changed 12 years ago by davidbuzz@…

Perhaps the original submitter's desire was to have the ability to build the application in one location/configuration, and not be constrained to keeping it in that precise path when it is "installed" into a new location (ie when the binaries are copied onto a different PC they can be put elsewhere).? It's common practice under windows to allow a use to do this, and "install" the application wherever they like. hard-coding paths at compile-time is very frowned apon.

Buzz.

comment:4 Changed 12 years ago by anonymous

Possibly. I think the current code allows for that without adding anything, by building with prefix=./lib or similar

comment:5 Changed 12 years ago by arnonm@…

I am the submitter, somehow the email didn't stick. Buzz is correct. This will allow win32 installation to be installed by default all under {appdir} and work OOB. Directory structure will be c:\program files\mythtv

lib share

Changing the installation directory, an option often present to win32 users, will require the installer to define MYTHCONFDIR and MYTHLIBDIR appropriately. However, if it is installed in the default above, these env variables will not be required, nor will a recompile be needed. In any case, it fits together and corresponds with 4612 mentioned.

comment:6 Changed 12 years ago by arnonm@…

A few more thoughts: While it is appropriate to install ming and recreate the unix directory structure on a development machine, it is not on the distribution destination. Having the end-user install mingw or create c:\mysys\1.0\share, etc is not the preferred method, or recompiling to a hard-coded installation location

comment:7 Changed 12 years ago by Nigel

Status: infoneeded_newnew

Move discussion to mailing list "Windows packaging" thread

comment:8 Changed 12 years ago by Nigel

Owner: changed from Isaac Richards to Nigel
Reporter: changed from anonymous to arnonm@…
Status: newaccepted
Ticket locked: set

comment:9 Changed 12 years ago by Nigel

Resolution: duplicate
Status: acceptedclosed

Replaced by #4984

Note: See TracTickets for help on using tickets.