Opened 12 years ago

Closed 12 years ago

#4949 closed defect (fixed)

make install_themes does not install themese in Win32

Reported by: arnonm@… Owned by: Isaac Richards
Priority: minor Milestone: 0.22
Component: theme Version: 0.21-fixes
Severity: medium Keywords: win32
Cc: Ticket locked: no

Description

Makefile in myththemese uses cp -f Source Destination and directory is ommited. cp -fr Source Destination solves this.

Change History (3)

comment:1 Changed 12 years ago by anonymous

This is strange. qmake reveals:

$ qmake -d myththemes.pro 2>&1 | grep _DIR
DEBUG 1: Project Parser: C:\msys\1.0\qt-3.3.x-p8\mkspecs\win32-g++\qmake.conf:96 :QMAKE_COPY_DIR: :=: ($(COPY) :: -r)
DEBUG 1: Project Parser: C:\msys\1.0\qt-3.3.x-p8\mkspecs\win32-g++\qmake.conf:99 :QMAKE_DEL_DIR: :=: (rmdir)
DEBUG 1: Project Parser: C:\msys\1.0\qt-3.3.x-p8\mkspecs\win32-g++\qmake.conf:102 :QMAKE_CHK_DIR_EXISTS: :=: (test :: -d)
DEBUG 1: Project Parser: myththemes\mythconfig.mak:478 :CONFIG_DIRECTX: :=: (yes)
DEBUG 1: Project Parser: myththemes\mythconfig.mak:483 :CONFIG_DEFINES: :=: (MMX :: i386 :: USING_DIRECTX)
DEBUG 1: Project Parser: C:\mythtv\myththemes\myththemes.pro:10 :QMAKE_COPY_DIR: :=: (sh :: ./cpsvndir)
DEBUG 1: CONFIG_DEFINES === MMX :: i386 :: USING_DIRECTX
DEBUG 1: CONFIG_DIRECTX === yes
DEBUG 1: QMAKE_CHK_DIR_EXISTS === test :: -d
DEBUG 1: QMAKE_COPY_DIR === sh :: ./cpsvndir
DEBUG 1: QMAKE_DEL_DIR === rmdir
DEBUG 1: QMAKE_INSTALL_DIR === $(COPY_DIR)

yet the generated Makefile has:

$ egrep _DIR Makefile
COPY_DIR        =       cp -f
DEL_DIR =       rmdir
CHK_DIR_EXISTS =        test -d
INSTALL_DIR = $(COPY_DIR)
OBJECTS_DIR = . 
MOC_DIR = . 
all: $(OBJECTS_DIR) $(MOC_DIR) $(TARGET)
$(OBJECTS_DIR):
        @if not exist $(OBJECTS_DIR) $(MKDIR) $(OBJECTS_DIR)
$(MOC_DIR):
        @if not exist $(MOC_DIR) $(MKDIR) $(MOC_DIR)
        @$(CHK_DIR_EXISTS) "$(INSTALL_ROOT)/usr/share/mythtv/themes" || $(MKDIR) "$(INSTALL_ROOT)/usr/share/mythtv/themes"
        -$(INSTALL_DIR) "Iulius" "$(INSTALL_ROOT)/usr/share/mythtv/themes/"
...

Adding a line 'QMAKE_INSTALL_DIR = sh ./cpsvndir' in myththemes.pro seems to work around this.

comment:2 Changed 12 years ago by Nigel

(In [17136]) Work around Win32 Qt3 make install bug. See #4949

comment:3 Changed 12 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [17137]) Work around Win32 Qt3 make install bug. I don't have thetime/motivation to fix this properly (i.e. patch the win32 patched qmake in qt-3.3.x-p8). Note that Qt 4 doesn't have this problem (it has a different one), so this does not need to be applied to trunk. Closes #4949

Note: See TracTickets for help on using tickets.