Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5057 closed defect (invalid)

Dolby Flag in XMLTV using na_dd is ignored

Reported by: Scott.Atkins@… Owned by: stuartm
Priority: trivial Milestone: 0.22
Component: mythfilldatabase Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

I hadn't seen a recording on my box with the dolby digital logo and went snooping through the database. All programs were set to either stereo or null. So I check my listing data through xmltv and found the dolby flag did exist, but the code in xmltvparser.cpp was expecting lower case, and the XMLTV output was in title case. Thus "Dolby" != "dolby" and items are not marked correctly.

According to the spec found in this post: http://forums.schedulesdirect.org/viewtopic.php?f=8&t=568#p3092

title case is correct. As such, I have a patch to add the title case as well as reporting unknown responses so something like this can be caught easier in the future.

Attachments (1)

dolby.patch (1.0 KB) - added by Scott.Atkins@… 12 years ago.
xmltvparser.cpp patch matching the title case of dolby

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by Scott.Atkins@…

Attachment: dolby.patch added

xmltvparser.cpp patch matching the title case of dolby

comment:1 Changed 12 years ago by Scott.Atkins@…

BTW, I would have converted the string to lower case in the code, but since I don't have a build environment, I wanted something that was reasonably bullet proof if it is applied (with the possible exception of a typo).

comment:2 Changed 12 years ago by stuartm

Component: mythtvmythfilldatabase
Milestone: unknown0.22
Owner: changed from Isaac Richards to stuartm
Priority: minortrivial
Severity: mediumlow
Version: unknownhead

The xmltv DTD calls for lower case - http://xmltv.cvs.sourceforge.net/xmltv/xmltv/xmltv.dtd?view=markup#l_420

So in this instance tv_grab_na_dd is incorrect.

However I will think about doing comparisons in lower case because it can't do any harm.

comment:3 in reply to:  2 Changed 12 years ago by Scott.Atkins@…

Replying to stuartm:

The xmltv DTD calls for lower case - http://xmltv.cvs.sourceforge.net/xmltv/xmltv/xmltv.dtd?view=markup#l_420

So in this instance tv_grab_na_dd is incorrect.

However I will think about doing comparisons in lower case because it can't do any harm.

Fair enough, I'll submit a bug to xmltv on this (in fact, I remember reading it, though I forgot to go back and check it when I figured out case was the issue). I think the ignored item reporting would be helpful. Just my opinion.

comment:4 Changed 12 years ago by stuartm

I spoke with Robert, indirectly, and he tells me that the current code is ok. I've checked the grabber (0.5.51) and he's correct, it should be lowercasing dolby. You may just need to upgrade to the latest version of XMLTV.

comment:5 Changed 12 years ago by stuartm

Resolution: invalid
Status: newclosed

comment:6 Changed 12 years ago by Scott.Atkins@…

I think my analysis was completely off, but I believe (and I'll check when I get home) that I have a version of xmltv which does the right thing. Can someone else check that the audioprops flag is set to something other than "" or "STEREO"?

comment:7 Changed 12 years ago by Scott.Atkins@…

Okay, yes this is completely invalid, there is nothing wrong with the xmltv parser, there is major trouble with data direct processor.

Note: See TracTickets for help on using tickets.