Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 6 years ago

Closed 6 years ago

Last modified 11 months ago

#5106 closed defect (fixed)

ATSCEvent ctor needs to init member vars

Reported by: Erik Hovland <erik@…> Owned by: danielk
Priority: trivial Milestone: 0.27
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The class ATSCEvent default ctor does not init any member vars.

Attachments (1)

libs_libmythtv_eithelper.h-init-ATSCEvent.patch (758 bytes) - added by Erik Hovland <erik@…> 6 years ago.
init ATSCEvent member vars in default ctor

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Erik Hovland <erik@…>

init ATSCEvent member vars in default ctor

comment:1 Changed 6 years ago by danielk

  • Owner changed from ijr to danielk
  • Status changed from new to assigned

I believe this is intentional for STL happiness + efficiency, but the reason should be documented in the class. I'll verify, and if I'm correct document this.

comment:2 Changed 6 years ago by danielk

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [17117]) Fixes #5106. Documents unusual construction for ATSCEvent.

comment:3 Changed 11 months ago by Stuart Morgan <smorgan@…>

In 3e0fd3cbc1897ec0570f15b837b60cd67eb34800/mythtv:

Initialise member variables in ATSCEvent. Strictly speaking this isn't
necessary as they are initialised immediately after creation, but all
static analysis tools complain about this and it's safer in the long
term

Refs #5106

comment:4 Changed 11 months ago by wagnerrp

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.