Opened 10 years ago

Closed 10 years ago

Last modified 5 years ago

#5106 closed defect (fixed)

ATSCEvent ctor needs to init member vars

Reported by: Erik Hovland <erik@…> Owned by: danielk
Priority: trivial Milestone: 0.27
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The class ATSCEvent default ctor does not init any member vars.

Attachments (1)

libs_libmythtv_eithelper.h-init-ATSCEvent.patch (758 bytes) - added by Erik Hovland <erik@…> 10 years ago.
init ATSCEvent member vars in default ctor

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Erik Hovland <erik@…>

init ATSCEvent member vars in default ctor

comment:1 Changed 10 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newassigned

I believe this is intentional for STL happiness + efficiency, but the reason should be documented in the class. I'll verify, and if I'm correct document this.

comment:2 Changed 10 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [17117]) Fixes #5106. Documents unusual construction for ATSCEvent.

comment:3 Changed 5 years ago by Stuart Morgan <smorgan@…>

In 3e0fd3cbc1897ec0570f15b837b60cd67eb34800/mythtv:

Initialise member variables in ATSCEvent. Strictly speaking this isn't
necessary as they are initialised immediately after creation, but all
static analysis tools complain about this and it's safer in the long
term

Refs #5106

comment:4 Changed 5 years ago by Raymond Wagner

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.