Opened 12 years ago

Closed 12 years ago

#5117 closed defect (duplicate)

Missed check of file desc from open() call in FIFOWriter::FIFOWriteThread()

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no


open() can fail. If it does then a negative file descriptor will be given. In FIFOWriter::FIFOWriteThread() there is a check to see if the fd is -1. If it is, call open. It does not check the fd after that open call. Then it gives the fd to write(). This could cause bad problems if that fd is still -1.

Attachments (1)

libs_libmythtv_fifowriter.cpp-always-check-fd-from-open.patch (895 bytes) - added by Erik Hovland <erik@…> 12 years ago.
check open() fd before calling write() with given fd

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by Erik Hovland <erik@…>

check open() fd before calling write() with given fd

comment:1 Changed 12 years ago by danielk

Resolution: duplicate
Status: newclosed

dup #5298

Note: See TracTickets for help on using tickets.