Opened 16 years ago

Closed 16 years ago

#5147 closed defect (fixed)

dereference of lType in ProgramRecPriority::updateList() is made outside of null check

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

At line 1430 in programs/mythfrontend/programrecpriority.cpp lType is dereferenced outside of the conditional that checks for null. Since lType might be null at this point it could be a segfault. The dereferenced should be put inside the null check.

Attachments (3)

programs_mythfrontend_programrecpriority.cpp-fix-forgotten-null-check.patch​ (1.0 KB) - added by Erik Hovland <erik@…> 16 years ago.
put lType dereference inside of null check conditional block
programs_mythfrontend-make-sure-check-for-null-is-done-ticket-5147.patch​ (2.8 KB) - added by Erik Hovland <erik@…> 16 years ago.
Latest version of the mythfrontend null checking patch
programs_mythfrontend-make-sure-check-for-null-is-done-ticket-5147.2.patch​ (3.1 KB) - added by Erik Hovland <erik@…> 16 years ago.
This patch adds one more null check. Forgotten in the attachment a few minutes ago

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: programs_mythfrontend_programrecpriority.cpp-fix-forgotten-null-check.patch​ added

put lType dereference inside of null check conditional block

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: programs_mythfrontend-make-sure-check-for-null-is-done-ticket-5147.patch​ added

Latest version of the mythfrontend null checking patch

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: programs_mythfrontend-make-sure-check-for-null-is-done-ticket-5147.2.patch​ added

This patch adds one more null check. Forgotten in the attachment a few minutes ago

comment:1 Changed 16 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [17538]) Fixes #5147. Adds a three needed null pointer checks in mythfrontend +a small cleanup.

Note: See TracTickets for help on using tickets.