Opened 16 years ago

Closed 16 years ago

#5157 closed defect (fixed)

checker doesn't like wonky code in EITFixUp::SetUKSubtitle()

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

This defect is only for readability. In libs/libmythtv/eitfixup.cpp at line 345, the static analysis checker I am using throws a parse error. I am guessing because the conditional is just too dense for it. Because it is even hard to read at first inspection. It would be nice if the code was made less clever.

Attachments (1)

libs_libmythtv_eitfixup.cpp-make-code-more-readable.patch​ (965 bytes) - added by Erik Hovland <erik@…> 16 years ago.
break count increment out of conditional to make analysis tool happy

Download all attachments as: .zip

Change History (2)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythtv_eitfixup.cpp-make-code-more-readable.patch​ added

break count increment out of conditional to make analysis tool happy

comment:1 Changed 16 years ago by danielk

Resolution: → fixed
Status: new → closed

Closed by [17217].

Note: See TracTickets for help on using tickets.