Opened 12 years ago

Closed 9 years ago

#5191 closed defect (Won't Fix)

[PATCH] Further fix ups for the UK EIT

Reported by: john {at} pullan {dot} org Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.25
Component: MythTV - EIT Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Another week another patch :-

  • Try not to duplicate the work in SetUKSubtitle
  • A much better attempt at splitting the ":" out of the descriptions etc
  • A more intelligent way of deciding when some thing is terminated by "!" or "?"
  • Added the"Law & Order" to the list of hacks (same as "CSI" and "CD")
  • Added a bit of code where if the subtitle exactly matches the title then it leaves it as it was.
  • Also added a bit of code to handle the "My name is earl: my name is prisoner 12345-123" (Now commented out!!)

Attachments (4)

eitfixup1.patch (8.2 KB) - added by john {at} pullan {dot} org 12 years ago.
fixup patches
eitfixup2.patch (9.1 KB) - added by anonymous 12 years ago.
eitfixup3.patch (9.7 KB) - added by john {at} pullan {dot} org 11 years ago.
eitfixup4.patch (10.3 KB) - added by john {at} pullan {dot} org 11 years ago.

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by john {at} pullan {dot} org

Attachment: eitfixup1.patch added

fixup patches

comment:1 Changed 12 years ago by Stuart Auchterlonie

Owner: changed from Isaac Richards to Stuart Auchterlonie
Status: newassigned

Changed 12 years ago by anonymous

Attachment: eitfixup2.patch added

comment:2 Changed 12 years ago by john {at}pullan {dot} org

eitfixup2.patch

Added more options for "BBC Switch" removal.

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup3.patch added

Changed 11 years ago by john {at} pullan {dot} org

Attachment: eitfixup4.patch added

comment:3 Changed 10 years ago by Stuart Auchterlonie

Milestone: 0.220.23

I'm bumping this to 0.23 unless someone wants to come up with a patch against current trunk.

Stuart

comment:4 Changed 10 years ago by stuartm

Component: mythtvMythTV - EIT

comment:5 Changed 10 years ago by Stuart Auchterlonie

Milestone: 0.230.24

I know this has been hanging around a while, but lets not go changing our eitfixups this close to a release.

Bumping to 0.24

Stuart

comment:6 Changed 9 years ago by robertm

Milestone: 0.240.25

Bumping to .25, I hear tickets reach their best vintage at the four year mark.

comment:7 Changed 9 years ago by robertm

Resolution: Won't Fix
Status: assignedclosed

Closing as hopelessly old. It seems like if there's no way to get someone to look at this for nearly four years, it's not getting any more likely as the patch becomes less and less relatable to our current code. This is *not* to say that there is anything wrong with the patch. I just suggest that someone produce a fresh, appliable one and then badger the hell out of us on the dev list to apply it.

Note: See TracTickets for help on using tickets.