Opened 12 years ago

Closed 11 years ago

#5272 closed patch (fixed)

MythWeb Advanced Scheduling Options

Reported by: lucien@… Owned by: Rob Smith
Priority: minor Milestone: unknown
Component: mythweb Version: 0.21
Severity: medium Keywords: easy
Cc: Ticket locked: no

Description

There are some problems with Advanced Scheduling Options in MythWeb, not really serious but annoying: I made following changes to file modules/tv/tmpl/default/_advanced

(<?php
                echo '<a href="#" onclick="toggle_advanced(false)" id="hide_advanced"';
                if (!$_SESSION['tv']['show_advanced_schedule'])
                    echo ' style="display: none"';
                echo '>', t('Hide'), '</a>',
                     '<a href="#" onclick="toggle_advanced(true)"  id="show_advanced"';
                if ($_SESSION['tv']['show_advanced_schedule'])
                    echo ' style="display: none"';
                echo '>', t('Display'), '</a>';
            ?>)

1) I added href="#" so that correct mouse cursor appears 2) I Changed Label from Show to Display to avoid translation issues (by example in German Show is translated by Sendung, what is not correct in this context)

Finally I added a Capital Letter fo german traslantion of Display, to be consistent to other similar labels like Hide.

Attachments (1)

ticket_5572.diff (1.0 KB) - added by laga 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by Rob Smith

Owner: changed from xris to Rob Smith
Status: newaccepted

comment:2 Changed 11 years ago by Rob Smith

Status: acceptedinfoneeded

Care to make this as a patch?

svn diff > foo.patch

and then attaching it to the ticket?

Changed 11 years ago by laga

Attachment: ticket_5572.diff added

comment:3 Changed 11 years ago by laga

Keywords: easy added
Status: infoneededassigned
Type: defectpatch

Patch against trunk is attached. Untested.

The translation change is already in trunk it seems.

comment:4 Changed 11 years ago by Rob Smith

Resolution: fixed
Status: assignedclosed

(In [19008]) Fixes #5272, this sets the advanced recording options display toggle to show the correct pointer icon, as well as change the wording slightly

Note: See TracTickets for help on using tickets.