Opened 12 years ago

Closed 11 years ago

#5312 closed patch (fixed)

Don't cache default values in the settings cache

Reported by: sphery <mtdean@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If a setting is not found in the database, the settings cache will store the default value passed to the Get*Setting() function. This means that future calls to Get*Setting() for that same setting value will end up with the default specified in the first call.

The attached simple patch changes this behavior by simply caching the value pulled from the DB (if appropriate) before assigning the default value. There is no new code in the patch, it simply rearranges 2 blocks of existing code. Once applied, Myth's behavior when getting settings values will be the same whether the settings cache is active or not.

Attachments (1)

mythtv-5312-do_not_cache_default_settings_values.patch (750 bytes) - added by sphery <mtdean@…> 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by sphery <mtdean@…>

comment:1 Changed 11 years ago by Nigel

(In [17636]) Don't cache default settings. Slightly different different patch to Michael's. See #5312

comment:2 Changed 11 years ago by Nigel

Resolution: fixed
Status: newclosed

(In [17637]) Don't cache default settings. Slightly different different patch to Michael's. Closes #5312

Note: See TracTickets for help on using tickets.