Opened 12 years ago

Closed 9 years ago

#5318 closed task (fixed)

QTimer audit

Reported by: danielk Owned by: danielk
Priority: minor Milestone: unknown
Component: MythTV - General Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Due to changes in how Qt handles QTimers in Qt4 all QTimer instances in MythTV need to be audited to ensure they still work.

Change History (10)

comment:1 Changed 11 years ago by Dibblah

Status: newassigned
Type: defecttask

comment:2 Changed 11 years ago by Roo

#5766 is an example of the problem (I think).

comment:3 Changed 10 years ago by paulh

Is this still a problem? Not heard of any QTimer problems.

comment:4 Changed 10 years ago by danielk

(In [21977]) Refs #5318. QTimer fixes.

Fixes an unsafe QTimer delete in httpcomms. I don't know if the QTimer usage is safe here, but this whole class should probably be phased out as it appears to be a hack around the lack of an event thread in individual QThread instances. Which was fixed in Qt4.

Fixes a double delete of the m_updateTimer in guidegrid.

Fixes a Qt4 out-of-create-thread start/stop problem with previewVideoRefreshTimer.

comment:5 Changed 10 years ago by danielk

(In [21978]) Refs #5318. QTimer fixes.

comment:6 Changed 10 years ago by danielk

Milestone: 0.220.23

I have not looked at LCD timer usage nor at the plugins, but I looked for glaring errors elsewhere. I marked the QTimer's that I'm pretty sure are ok with an "audited #5318" comment in the header.

comment:7 Changed 10 years ago by stuartm

Component: mythtvMythTV - General

comment:8 Changed 10 years ago by danielk

Milestone: 0.23unknown

comment:9 Changed 9 years ago by danielk

AFAIK all these Qt4 port QTimer issues are fixed in trunk.

comment:10 Changed 9 years ago by danielk

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.