Opened 12 years ago

Closed 10 years ago

#5338 closed enhancement (fixed)

Watched flag for mythvideo

Reported by: ille Owned by: robertm
Priority: minor Milestone: 0.22
Component: mythvideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

A patch against 0.21-fixes as a first step that implements a watched flag in the database and a "Toggle watched" item under the info button in the different views and in the video manager. The filter function is updated with this new flag so you can filter and only present what is not watched.

The next step would be make the watched flag toggle as on tv-recordings and make the flag somehow change the color of a not watched movie.

Tha patch is against 0.21-fixes , i would guess it needs to be written against SVN.

Attachments (2)

mythvideo_watched.patch (41.6 KB) - added by ille 12 years ago.
MythVideo.Watched.081109.diff (24.1 KB) - added by robertm 10 years ago.
Preliminary patch for trunk. Theme support not included yet.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by ille

Attachment: mythvideo_watched.patch added

comment:1 Changed 12 years ago by Anduin Withers

Component: mythtvmythvideo
Owner: changed from Isaac Richards to Anduin Withers
Status: newassigned

Feature patches, not generated from trunk, are at the bottom of the pile.

comment:2 Changed 12 years ago by yourimatthys@…

Applied you patch against SVN and the toggling works as expected. Had to exclude the patch for videofilter.cpp though as make didn't want to compile. Gave me an error on kWatchedFilterAll.

comment:3 Changed 12 years ago by yourimatthys@…

Should I create the diffs for the SVN?

comment:4 in reply to:  3 Changed 12 years ago by anonymous

Replying to yourimatthys@gmail.com:

Should I create the diffs for the SVN?

yes you could, but would be great if you could post the compile error for videofilter.cpp

comment:5 Changed 10 years ago by stuartm

Milestone: 0.21.10.22
Status: assignedinfoneeded

Please update the patch for trunk

comment:6 Changed 10 years ago by robertm

Status: infoneededassigned
Version: 0.21-fixeshead

I have a trunk version of this mostly done, will commit in the next few days.

comment:7 Changed 10 years ago by robertm

Owner: changed from Anduin Withers to robertm

Changed 10 years ago by robertm

Preliminary patch for trunk. Theme support not included yet.

comment:8 Changed 10 years ago by robertm

Resolution: fixed
Status: assignedclosed

(In [21217]) Closes #5338. Adds a 'Watched' Flag to MythVideo? to match the one in Watch Recordings. Operates exactly as in recordings-- If the setting to automatically mark recordings as watched is on, videos will also be automatically marked as watched using the same method. Otherwise, one can mark a video watched in MythVideo? in the Edit Metadata screen or in Manage Video->Toggle Watched. Can sort by watched. Suffers from the same bug as scanning-- when a video is marked as watched during playback, it will not stick in the UI until leaving MythVideo? and waiting for the cache to die.

Note: See TracTickets for help on using tickets.