Opened 12 years ago

Closed 11 years ago

#5345 closed patch (fixed)

mythvideo file associations cannot be created

Reported by: joant@… Owned by: Anduin Withers
Priority: minor Milestone: 0.22
Component: mythvideo Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The default constructor for the internal FileAssociation? class in mythvideo/fileassoc.cpp does not set the value for the external command member. Unless the user sets the external command value to "Internal" or an appropriate alternate value, the INSERT will fail the NOT NULL constraint on the videotypes table.

I also changed the default null values in the mythvideo/dbcheck.cpp file for the avi, txt and log file extensions to "Internal" or "/bin/false" to maintain table integrity.

Found while using the glass-wide theme, which has a bug that prevents viewing or editing the external command on the MythVideo? file associations page. This exacerbated the problem.

Attachments (1)

mythvideo_file_assoc_patch.diff (2.2 KB) - added by joant@… 12 years ago.
Patch as promised

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by joant@…

Patch as promised

comment:1 Changed 12 years ago by Anduin Withers

Milestone: unknown0.22

comment:2 Changed 11 years ago by Dibblah

Status: newassigned

comment:3 Changed 11 years ago by Anduin Withers

Resolution: fixed
Status: assignedclosed

(In [19443]) Closes #5345

Prevents null QString for playcommand insertion in videotypes.

Thanks to joant at itriplee

Note: See TracTickets for help on using tickets.