Opened 11 years ago

Closed 11 years ago

#5369 closed patch (wontfix)

reduce dirty region check interval of mythtv ui

Reported by: ard.biesheuvel@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: low Keywords: repaint ui
Cc: Ticket locked: no

Description

Running powertop on my idle AppleTV frontend reveals that 77% of the wakeups from idle are caused by MythTV repainting its UI 70 times per second. The attached patch reduces this to 5 times per second, and doesn't have any side effects, as far as I can tell.

Attachments (1)

myth_repaint_ui.diff (394 bytes) - added by ard.biesheuvel@… 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by ard.biesheuvel@…

Attachment: myth_repaint_ui.diff added

comment:1 Changed 11 years ago by stuartm

Resolution: wontfix
Status: newclosed

Aside from making animation impossible.

comment:2 Changed 11 years ago by stuartm

Owner: changed from Isaac Richards to stuartm

Which theme are you using?

comment:3 Changed 11 years ago by ard.biesheuvel@…

I'm using Retro, and I don't think it has any animations, does it? The same goes for the other (conventional) themes I've used.

The point is, even if 5Hz is insufficient for animations, repainting the UI 70 times per second all the time (as even mythwelcome does) is unnecessary, and interferes with the power saving features of the kernel and the hardware.

comment:4 Changed 11 years ago by stuartm

Resolution: wontfix
Status: closednew

We shouldn't be repainting all the time, when it was pointed it out to me that we might be even with no animations I thought I better check which theme you were using.

Which painter are you using?

comment:5 Changed 11 years ago by ard.biesheuvel@…

I use Qt, although OpenGL produces the same results wrt the number of wakeups.

comment:6 Changed 11 years ago by stuartm

Summary: reduce repaint interval of mythtv uireduce dirty region check interval of mythtv ui

Ok, so it's not repaints which are causing the wakeups it's the draw timer, which only triggers a repaint if something has changed.

comment:7 Changed 11 years ago by stuartm

Resolution: wontfix
Status: newclosed

The patch is wrong, but if someone wants to implement the correct solution by replacing polling entirely then I'll look at this again.

Note: See TracTickets for help on using tickets.