Opened 12 years ago

Closed 12 years ago

#5404 closed patch (fixed)

Missing includes needed when compiling on newer g++

Reported by: Mario Limonciello <superm1@…> Owned by: danielk
Priority: minor Milestone: 0.21.1
Component: mythmusic Version: 0.21-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi, I'm doing a test compile of the 0-21-fixes branch on Intrepid Ibex, and mythplugins fails to build, particularly mythmusic.

It turns out on the copy of g++ in Intrepid, you need to include the malloc.h header to allow it to be used.

# g++ --version g++ (Ubuntu 4.3.0-5ubuntu1) 4.3.1 20080525 (prerelease) Copyright (C) 2008 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Attachments (1)

12_missing_malloc.dpatch (1.2 KB) - added by Mario Limonciello <superm1@…> 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Mario Limonciello <superm1@…>

Attachment: 12_missing_malloc.dpatch added

comment:1 Changed 12 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newaccepted

comment:2 Changed 12 years ago by Mario Limonciello <superm1@…>

I got an email indicating this:


Hi,

your patch 12_missing_malloc.dpatch includes malloc.h for malloc(), instead of stdlib.h as it is documented in the malloc(3) manpage.

Regards, Tino


This should be included instead it would appear (although both should work)

comment:3 Changed 12 years ago by danielk

Resolution: fixed
Status: acceptedclosed

(In [17514]) Fixes #5404. Header cleanup.

Note: See TracTickets for help on using tickets.