Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#541 closed enhancement (fixed)

EIT: disable on an entire video source

Reported by: danielk Owned by: danielk
Priority: minor Milestone: 0.19
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by danielk)

Right now you need to disable EIT for each channel on a source in order to disable it completely for that source.

Attachments (3)

videosource.patch (5.7 KB) - added by John Pullan <john.pullan@…> 14 years ago.
First pass at a "stop EIT scanning" patch
videosource1.patch (4.6 KB) - added by John Pullan <john.pullan@…> 14 years ago.
videosource.2.patch (9.3 KB) - added by John Pullan <john.pullan@…> 14 years ago.
Patch to force eit scan to be on for eitonly grabber

Download all attachments as: .zip

Change History (18)

comment:1 Changed 14 years ago by danielk

Description: modified (diff)
Owner: changed from Isaac Richards to danielk
Summary: It would be nice to be able to disble EIT on an entire video sourceEIT: disable on an entire video source
Type: defectenhancement

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: videosource.patch added

First pass at a "stop EIT scanning" patch

comment:2 Changed 14 years ago by John Pullan <john.pullan@…>

Type: enhancementpatch

The attached patch adds a new xmltv source into video sources. If you set it to use the "on air guide" then it works as before.

I've not removed the on useonairguide column from channel but this probably needs to be done as well. Feedback welcome.

comment:3 Changed 14 years ago by danielk

Priority: trivialminor
Type: patchenhancement

Not quite right.

I like the idea of a EIT only video source, but you should be able to use other listings sources with the OTA EIT data as well. You also still need the per channel "useonairguide", some ATSC channels still deliver such useful information as "DTV program:30 minutes" for many of their programs.

comment:4 Changed 14 years ago by John Pullan <john.pullan@…>

Surely you'd define another videosource in that case ?

comment:5 Changed 14 years ago by danielk

It's usually only one or maybe two channels in the entire lineup. The stations have to pay a fine for every day they fail to comply with their license obligations. And the federal government could pull their license when it comes up for renewal if they don't have a good enough excuse for breaking the law.

So no you would just tell EIT to ignore that station.

This used to be a much bigger problem before last July when the EIT data was optional; which is why ATSC people didn't care all that much about EIT parsing back then.

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: videosource1.patch added

comment:6 Changed 14 years ago by John Pullan <john.pullan@…>

The updated patch retains each channels on air guide option, but it also defaults it to off from scan. (Allowing you to set an alternate guide for most of the channels apart from the ones you want to grab the guide from the air)

If you want to use on air guide then goto video source etc.

comment:7 Changed 14 years ago by Stuart Auchterlonie

There is a problem with this. When you set onairguide to false by default, the active scanner is left with no channels to scan.

You will need to set useonairguide to true if you are using your datasource, and false otherwise (if you wish to have false as the default).

comment:8 Changed 14 years ago by anonymous

If you are using the onairguide then that will allow the channel to be scanned (?) or I've missed a test somewhere.

comment:9 Changed 14 years ago by Stuart Auchterlonie

The Active EIT Scan uses the condition that onairguide=1 to determine which channels to scan.

See EITScanner::StartActiveScan?()

comment:10 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [7659]) Closes #541.

This adds the EIT only listings source created by John Pullan and adds a column to videosource called useeit, which when set will allow the EITScanner to scan channels on any DTV source. I've disabled this by default so that if you compile with EIT parsing enabled, it default to NOT using EIT information, so you must set this to true if you want EIT events.

You can still disable EIT scanning for any particular channel by editing the channel.

To enable/disable EIT scanning for a source edit the source in the "Video Source" configuration pane of the backend configuration.

comment:11 Changed 14 years ago by Stuart Auchterlonie

Comments:

  • The condition "AND capturecard.hostname = :HOSTNAME"

has been removed from channelsettings.cpp

  • When selecting onairguide as the data source, the

rest of the xmltv box isn't cleared making it try and run either brazilian tv_grab or north american data direct depending on which direction you have selected it from.

comment:12 Changed 14 years ago by john.pullan@…

It appears that if you want active scan to work you need to

a) Select the eit grabber

b) set the check box

c) make sure it's set on the channel (which admittedly it should be after a scan)

This seems a somewhat convoluted way of doing things. Surly a) implies b) ? Couldn't we get rid of the eit grabber (if we must) or alter the logic for active scan. (Also is more logic required in dbox2epg ?)

comment:13 Changed 14 years ago by danielk

The condition "AND capturecard.hostname = :HOSTNAME" has been removed from >channelsettings.cpp

It didn't make any sense, this is a query about a particular source. It can't used for DVB on one backend and not another, and if you are editing it you would want to be able to edit its options no matter what backend you are running on.

When selecting onairguide as the data source, the rest of the xmltv box isn't cleared making it try and run either brazilian tv_grab or north american data direct depending on which direction you have selected it from.

Ok, that sounds like a bug.

It appears that if you want active scan to work you need to...

Yes, rather convoluted. I'd like it if the checkbox was set automatically when you create an eit only source... I figured I would add your enhancement as is and then you would make it work better :)

As for the channel's useonairguide setting, that should be set by the scan, the user would have had to explicitly disable it for it to be disabled. In which case I'm assuming they can unset it.

Changed 14 years ago by John Pullan <john.pullan@…>

Attachment: videosource.2.patch added

Patch to force eit scan to be on for eitonly grabber

comment:14 Changed 14 years ago by John Pullan <john.pullan@…>

I've made some alterations to the videosource UI. I think it's better but I'm sure you'll tell me if its not :)

What this patch does :

Removes some redundent classes for tv_grab_uk (no longer supported)

Moves the useeit checkbox into the individual grabber selection panes

Removes the useeit checkbox from the eit only grabber and forces the setting on in the videosource table.

Alters the label text for eit only grabber to use three labels so you can read it.

comment:15 Changed 14 years ago by danielk

(In [7679]) References #541.

Applies John Pullan's patch for improving the VideoSource? UI with respect to EIT scanning.

The patch also gets rid of the configuration for the old UK grabber, "tv_grab_uk". We've supported the replacement "tv_grab_uk_rt" for some time...

Note: See TracTickets for help on using tickets.