Opened 16 years ago

Closed 16 years ago

#5423 closed defect (fixed)

compile parse error in jobsqueue member function QueueJobs

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

Because a ctor for QDateTime is called with the class scope the g++ compile throws a parse error. Now this is not a parse error that ever gets thrown out to the user. Instead g++ notices it and says 'Oh, what they really want is this' and moves on. But programs that use the parsed output of the compiler (like static analysis checkers) cannot analyze the source code that includes this header file. So that means that the analyzer cannot check things like tv_rec.cpp, tv_play.cpp or NuppleVideoPlayer?.cpp. Which are perhaps some of the most heavily used classes in libmythtv. So it would be nice if this one liner could be put in fairly soon.

Attachments (1)

libs_libmythtv-compiler-parse-error-jobsqueue.h.patch​ (969 bytes) - added by Erik Hovland <erik@…> 16 years ago.
removes class scoping from ctor call

Download all attachments as: .zip

Change History (2)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythtv-compiler-parse-error-jobsqueue.h.patch​ added

removes class scoping from ctor call

comment:1 Changed 16 years ago by Anduin Withers

Resolution: → fixed
Status: new → closed

(In [17453]) Closes #5423

Remove unnecessary class scope use when ctor called. Patch from Erik Hovland.

Note: See TracTickets for help on using tickets.