Opened 12 years ago

Closed 12 years ago

#5425 closed defect (fixed)

subitem = new OSDGenericTree is superfluous

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The assignment of the pointer returned from the heap allocation of a OSDGenericTree is only necessary if that pointer is going to be used to add sub items to that tree. Otherwise, it just causes extra instructions to be generated.

Attachments (1)

libs_libmythtv-unused-value.patch (18.9 KB) - added by Erik Hovland <erik@…> 12 years ago.
removes any unused assignments from the code in the libs/libmythtv directory

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by Erik Hovland <erik@…>

removes any unused assignments from the code in the libs/libmythtv directory

comment:1 Changed 12 years ago by Erik Hovland <erik@…>

The first change in the attached patch is not about OSDGenericTree. In fact, I worried over putting it into its own patch. Anyhow, there is a strange assignment and then another assignment (after a lock is grabbed) in NuppelVideoPlayer::DisplayAVSubtitles. I shortened it to one assignment (before the lock). I will gladly rework that part of the patch or break it out if it needs to get a bit more introspection.

comment:2 Changed 12 years ago by danielk

Resolution: fixed
Status: newclosed

(In [17603]) Fixes #5425. Removes some silly assignments and generally cleans up the OSD menu code.

Note: See TracTickets for help on using tickets.