Opened 11 years ago

Closed 11 years ago

#5491 closed defect (fixed)

MythMusic search result insert error

Reported by: otto at kolsi dot fi Owned by: stuartm
Priority: minor Milestone: unknown
Component: mythmusic Version: 0.21-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

There's following bug in MythMusic:

Enter to MythMusic so that there are songs in playlist (automatically saved during earlier session). Using '3' and the music tree, clear the playlist and select something else to it and esc back to player. Now select Menu and Search and then select just some song and Enter -> select "Insert after current track".

-> Playlist is changed to contain the songs that you had there when you first entered MythMusic and not those that you later selected from the music tree.

Change History (3)

comment:1 Changed 11 years ago by otto at kolsi dot fi

If anyone is interested in helping, here are my findings so far:

Playlist::fillSonglistFromQuery() gets called when the new track is inserted into the current playlist from the search results. However, this function manipulates internal variable 'raw_playlist' which IS NOT in correct state when the bug occurs.

When fillSonglistFromQuery() gets called after changing current playlist through 'Edit playlist' function, the 'raw_playlist' still contains the previous playlist which was loaded earlier (when MythMusic was launched e.g.).

So my fix would be to update the 'raw_playlist' inside Playlist object immediately after current playlist is changed when using 'Edit playlist' function.

This sounds like some corner case, but this can easily happen when you search some songs from the library.. and then the whole current playlist is blown away. Not very nice when you are having party or something similar :)

comment:2 Changed 11 years ago by stuartm

Owner: changed from Isaac Richards to stuartm
Status: newassigned

comment:3 Changed 11 years ago by stuartm

Resolution: fixed
Status: assignedclosed

(In [18454]) Fix for old playlist re-appearing when appending tracks to the new list using the Search. Closes #5491. Will backport to -fixes once it receives sufficient testing in trunk.

Note: See TracTickets for help on using tickets.