Opened 11 years ago

Closed 11 years ago

#5498 closed patch (fixed)

ALSA getSpaceOnSoundcard mixing frames and bytes

Reported by: David Asher <david.asher@…> Owned by: danielk
Priority: minor Milestone: 0.22
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

I'm using release-0-21-fixes, so that's what the patch is against.

This is a minor issue, since I think it will only matter in an error case, but the return value of snd_pcm_avail_update() (which is in frames) is being compared to soundcard_buffer_size (which is in bytes). The attached patch is untested (my current system is not set up to compile mythtv).

Attachments (1)

audiooutputalsa.cpp.patch (709 bytes) - added by David Asher <david.asher@…> 11 years ago.
patch to compare bytes with bytes

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by David Asher <david.asher@…>

Attachment: audiooutputalsa.cpp.patch added

patch to compare bytes with bytes

comment:1 Changed 11 years ago by danielk

Owner: changed from Isaac Richards to danielk
Status: newassigned

comment:2 Changed 11 years ago by danielk

Milestone: unknown0.22
Type: defectpatch
Version: unknownhead

comment:3 Changed 11 years ago by danielk

Resolution: fixed
Status: assignedclosed

(In [19473]) Fixes #5498. Fixes frame vs. bytes confusion in ALSA error check.

Note: See TracTickets for help on using tickets.