Opened 16 years ago
Closed 15 years ago
#5515 closed defect (fixed)
pointer check before dereference in NuppelVideoPlayer.cpp and tv_play.cpp
| Reported by: | Owned by: | Isaac Richards | |
|---|---|---|---|
| Priority: | trivial | Milestone: | unknown |
| Component: | mythtv | Version: | head |
| Severity: | low | Keywords: | |
| Cc: | Ticket locked: | no |
Description
The latest round of pointer check before dereferencing in libmythtv. These patches are against probably the most heavily used code paths. So their importance are probably low and their chance of screwing things up are high. So feel free to give the patches extra testing before accepting them.
Attachments (2)
Change History (4)
Changed 16 years ago by
| Attachment: | libs_libmythtv-forward-null.patch added |
|---|
Changed 16 years ago by
| Attachment: | libs_libmythtv-forward-null-ticket-5515.patch added |
|---|
Latest version of the pointer check patch for libmythtv
comment:1 Changed 16 years ago by
The most interesting part of the new patch is the change in tv_rec.cpp in TuningNewRecorder?. I believe that the way that the V4LChannel object is used is not correct and only the base class member functions are called (which have only stub implementations).
Otherwise it is the same patch as before with a few more checks.
comment:2 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [19445]) Fixes #5515. Few more null pointer checks.
Note: I did not apply the GuideGrid?.cpp portion of the patch, those pointers are guarranteed to be valid. Nor did I apply the dynamic_cast<> for the ivtv decoder, also guarranteed. And the V4LChannel changes in tv_rec.cpp are also not needed, C++ inheritance takes care of dispatching those methods correctly for us (you only need to worry about unexpected virtual dispatch in dtors).
checks pointers before dereference of said pointer