Opened 11 years ago

Closed 11 years ago

#5542 closed defect (wontfix)

win32-packager.pl needs encapsulation of windows paths in " to allow for spaces in path names

Reported by: jonathan@… Owned by: danielk
Priority: major Milestone: unknown
Component: windows Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Since my MinGW/MSys installation is installed already in the C:\Program Files folder the win32-packages.pl is exiting all the time a file or folder in the Program Files folder is accessed as the script does not allow for spaces in file/directory names. This can be easily solved by quoting the paths and filenames with a double quote.

(I've set the component to windows as I though this is the most appropriate)

Change History (4)

comment:1 Changed 11 years ago by davidbuzz@…

Your problem can be even more easily solved by you following the standard practice of installing mingw in c:/mingw and msys in c:/msys/1.0/ , neither of which has spaces. If that offends you too much, then try using the 8.3 filenaming convention for your directory - al-ah: c:\progra~1\MinGW\

Unless you supply a fully tested patch for witespace support in paths, it's not going to be changed, as the existing quoting mechanisms are already complex enough ( with PERL, DOS, and UNIX path conventions all already being used).

trac-master, please close this ticket as "wontfix".

comment:2 in reply to:  1 Changed 11 years ago by anonymous

Replying to davidbuzz@gmail.com:

Your problem can be even more easily solved by you following the standard practice of installing mingw in c:/mingw and msys in c:/msys/1.0/ , neither of which has spaces.

Isn't that a bit short sighted? MythTV on it's on is configured to be compiled in a highly flexible environment, but you seem not to be willing to implement this for the win32 packager to apply to a default windows environment using paths with spaces in filenames, other than installing a second instance of MSys (in the C root or recoding all file paths to 8.3 filename styles and the script as well).

If that offends you too much, then try using the 8.3 filenaming convention for your directory - al-ah: c:\progra~1\MinGW\

Yes it does as I use that environment for other purposes as well, I would think my suggestion would be a welcome addition to make the script more fail proof, it is a pity that you are requiring a patch for every suggestion I try to make as you seem to know the script a lot better than I do.

Unless you supply a fully tested patch for witespace support in paths, it's not going to be changed, as the existing quoting mechanisms are already complex enough ( with PERL, DOS, and UNIX path conventions all already being used).

I'll see what I can do, but I am limited on time as much as you are I guess.

trac-master, please close this ticket as "wontfix".

I would suggest leaving this open for a while to give me time to prepare a patch.

comment:3 Changed 11 years ago by davidbuzz@…

I responded to last comment on the mythtv-dev mailing list, as mythtv trac is not supposed to be used as a "discussion tool". :-)

comment:4 Changed 11 years ago by danielk

Resolution: wontfix
Status: newclosed

This has been open for a month without promised patch being submitted, closing as wontfix.

Note: See TracTickets for help on using tickets.