Opened 16 years ago

Closed 16 years ago

#5563 closed defect (fixed)

rev 17858 introduces a potential segfault in xmlparsebase.cpp

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

The code inserted by commit of svn rev 17858 introduces a potential segfault. The added if clause includes a dereference of the parent pointer. That pointer might be null. If it is, this code will cause a segfault.

The patch changes the if clause to the not version and wraps the other if clauses in it, but the parent && is the only part required.

Attachments (1)

libs_libmythui-null-check-of-parent-required.patch​ (3.0 KB) - added by Erik Hovland <erik@…> 16 years ago.
makes sure parent is not null before dereferencing

Download all attachments as: .zip

Change History (2)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: libs_libmythui-null-check-of-parent-required.patch​ added

makes sure parent is not null before dereferencing

comment:1 Changed 16 years ago by stuartm

Resolution: → fixed
Status: new → closed

(In [17885]) Close #5563, prevent segfault(s) in ParseChildren?() if the pointer parent is NULL. Should parent be null here then we've much bigger problems but crashing should be avoided.

Note: See TracTickets for help on using tickets.