Opened 16 years ago

Closed 16 years ago

#5575 closed defect (fixed)

check pointer before dereferencing in mythphone

Reported by: Erik Hovland <erik@…> Owned by: Isaac Richards
Priority: trivial Milestone: unknown
Component: mythphone Version: head
Severity: low Keywords:
Cc: Ticket locked: no

Description

sipMsg is checked at the beginning of ::FSM() so it should be checked throughout. My guess is that sipMsg is almost never null so maybe this code could be reworked differently. But the attached patch assumes it can be null and always checks it before dereferencing.

Attachments (2)

mythphone-check-for-null.patch​ (12.7 KB) - added by Erik Hovland <erik@…> 16 years ago.
checks for null where necessary, before dereferencing
mythphone-check-for-null.2.patch​ (12.7 KB) - added by Erik Hovland <erik@…> 16 years ago.
Additional null checks

Download all attachments as: .zip

Change History (3)

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: mythphone-check-for-null.patch​ added

checks for null where necessary, before dereferencing

Changed 16 years ago by Erik Hovland <erik@…>

Attachment: mythphone-check-for-null.2.patch​ added

Additional null checks

comment:1 Changed 16 years ago by paulh

Resolution: → fixed
Status: new → closed

(In [18308]) NULL pointer checks in MythPhone?. Fixes #5575. Untested other than to make sure it still compiles under Linux.

Note: See TracTickets for help on using tickets.