Opened 11 years ago

Closed 10 years ago

#5578 closed patch (fixed)

Transcoded flag is not set when the other program flags are, and Mythweb to display Transcoded flag

Reported by: simonwalls@… Owned by: Rob Smith
Priority: minor Milestone: 0.23
Component: Plugin - MythWeb Version: head
Severity: medium Keywords: transcode libmythtv mythweb easy
Cc: Ticket locked: no

Description (last modified by laga)

I have an interest in Mythweb showing when a program has been transcoded, since the 'Recently Completed Jobs' display disappears after some time (hours/days). I would like to know in perpetuity when a program has been transcoded (so, for example, I don't transcode it again.....)

In digging into the detail, I found the 'transcoded' field in the 'recorded' database table. This is (correctly) set when a transcode finishes -- but later on, it is not read out into the bit-flags which Mythweb uses to determine the display for a particular recording. And libmythtv is where that reading is done.

So I have created a patch for libmythtv (to set the 'transcoded' bit-flag) and a patch for Mythweb (to change the display, for a recorded program only, to show the transcoded state).

The patch for libmythtv is complete as attached. The mythweb one works as attached but could be improved - it just shows the Transcoded state as a bit of text (TRANSCODED / NON-TRANSCODED), after the stereo/closed-caption icons. This use of text is because I read someplace that most (if not all) Mythtv themes do not contain a 'Transcoded' icon, and I have zero knowledge of themes in general. The icon could be there - I could be wrong - but my intent was just to get the functionality done. I'll leave it to the theme experts and designers to make it look good.

The patches are for 0.21-fixes SVN 17451.

All the best, Simon.

Attachments (3)

libmythtv_transcodepatch.diff (1.0 KB) - added by simonwalls@… 11 years ago.
Patch for libmythtv (0.21-fixes SVN 17451) to read the transcoded program flag out of the database
mythweb_transcodepatch.diff (2.6 KB) - added by simonwalls@… 11 years ago.
mythweb patch (0.21-fixes SVN 17451) to display the Transcoded flag as plain text, for a recorded program
mythweb-transcodepatch-trunk.diff (2.1 KB) - added by simonwalls@… 11 years ago.
revised patch for mythweb in Trunk version 18494

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by simonwalls@…

Patch for libmythtv (0.21-fixes SVN 17451) to read the transcoded program flag out of the database

Changed 11 years ago by simonwalls@…

Attachment: mythweb_transcodepatch.diff added

mythweb patch (0.21-fixes SVN 17451) to display the Transcoded flag as plain text, for a recorded program

comment:1 Changed 11 years ago by laga

Description: modified (diff)
Status: newinfoneeded_new

libmythtv_transcodepatch.diff still applies to trunk, albeit with some offset.

However, mythweb_transcodepatch.diff doesn't apply anymore. Can you provide an updated patch? Thanks!

comment:2 Changed 11 years ago by simonwalls@…

Here is a replacement for mythweb_transcodepatch.diff called mythweb-transcodepatch-trunk.diff

I have not compiled it locally as I have no Trunk installation, but it looks like the changes are the same, merely the file name has changed.

If any difficulty, report back on this ticket and I will install a full trunk and compile it, hopefully I will spot any bugs.

Thanks, Simon.

Changed 11 years ago by simonwalls@…

revised patch for mythweb in Trunk version 18494

comment:3 Changed 11 years ago by laga

Keywords: easy added
Status: infoneeded_newnew

comment:4 Changed 11 years ago by Dibblah

Owner: changed from Isaac Richards to xris
Status: newassigned

comment:5 Changed 10 years ago by stuartm

Component: mythtvPlugin - MythWeb
Milestone: unknown0.23
Version: 0.21-fixeshead

comment:6 Changed 10 years ago by stuartm

(In [22516]) Set the transcoded flag in getProgramFlags, looks like an oversight that it hasn't be set before now. Thanks to Simon Walls for the patch. Refs #5578

comment:7 Changed 10 years ago by stuartm

Owner: changed from xris to Rob Smith

The mythweb portions of this ticket should be an easy fix.

comment:8 Changed 10 years ago by stuartm

(In [22517]) Backport [22516] to -fixes. Load the transcoded flag in programinfo to fix display of the transcoded icon in Watch Recordings and Mythweb. Refs #5578

comment:9 Changed 10 years ago by Rob Smith

Resolution: fixed
Status: assignedclosed

(In [23680]) Fixes #5578, this will display if the program has been transcoded on the recording details page.

Note: See TracTickets for help on using tickets.