Opened 10 years ago

Closed 10 years ago

#5592 closed task (fixed)

Port libmythupnp to qt4

Reported by: danielk Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description


Attachments (2)

upbp-qt4-v1.patch (140.1 KB) - added by danielk 10 years ago.
Initial patch, still largely untested.. Once I'm assured that it's working correctly I'll refactor it a bit before committing.
5592-v2.patch (140.0 KB) - added by danielk 10 years ago.
patch with just the typo fix and the two fixes needed for Qt4.3 & OSX

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by danielk

Attachment: upbp-qt4-v1.patch added

Initial patch, still largely untested.. Once I'm assured that it's working correctly I'll refactor it a bit before committing.

comment:1 Changed 10 years ago by danielk

Note: there is a typo on line 34 of eventing.cpp in the patch. Remove the extra ";". I'll submit an updated patch with this and other fixed after some more testing.

comment:2 Changed 10 years ago by Nigel

After eventing.cpp fix, Linux Qt 4.4 BE built OK, and my 1 UPnP hardware device seems to browse/play OK against it. Mac OS X Qt 4.3 build was a bit harder:

  1. QT_BEGIN_NAMESPACE/QT_END_NAMESPACE in mmembuf.h are incompatible with Qt 4.3 builds
  2. I had to also add #include <stdint.h> in there (for uint64_t on Mac OS X)

but after that, it built and the client (backend chooser) works OK. (well, as well as SVN head does)

Changed 10 years ago by danielk

Attachment: 5592-v2.patch added

patch with just the typo fix and the two fixes needed for Qt4.3 & OSX

comment:3 Changed 10 years ago by Nigel

Resolution: fixed
Status: newclosed

This was resolved by [18011], but it looks like Trac didn't get the update

Note: See TracTickets for help on using tickets.