Opened 11 years ago
Closed 10 years ago
#5603 closed patch (fixed)
programid's and seriesid's should not be used without an authority
Reported by: | Owned by: | Janne Grunau | |
---|---|---|---|
Priority: | minor | Milestone: | 0.22 |
Component: | eit | Version: | head |
Severity: | low | Keywords: | |
Cc: | Stuart Auchterlonie, stuartm | Ticket locked: | no |
Description
According to ETSI TS 102 323, CRIDs in content_identifier_descriptor's must have an explicit authority or a default_authority found in the SDT, BAT or NIT.
MythTV uses the identifier anyway even though it may conflict with other services without a default_authority set and give false programme and series matches.
This patch corrects this by ignoring truncated CRIDs when no default authority can be found. The patch will strip the "crid://" part from fully specified CRIDs. The patch also adds the ability to obtain the default authority from the first or second loops in the NIT and stores these, if present, with the multiplex information.
(NIT authorities tested using simulated Crystal Palace signal)
Attachments (1)
Change History (12)
Changed 11 years ago by
Attachment: | network_default_authority.patch added |
---|
comment:1 Changed 11 years ago by
Cc: | Stuart Auchterlonie added |
---|
comment:2 Changed 11 years ago by
Cc: | stuartm added |
---|
comment:3 Changed 11 years ago by
In a related ticket #5562, we aren't populating the default authority descriptor when scanning astra (or probably any dvb-s for that matter)
comment:4 Changed 11 years ago by
The problem there is that there is no scan whatsoever of the BAT. The retrieval of the default authority from there should behave in a similar way to the NIT default authority in my patch. So I'd suggest this patch should be a requirement of any fix for #5562.
I'm trying to add BAT parsing into my local copy and may have a patch for #5562 soon. I think I have made the relevant changes but I'm just having a bit of trouble getting the Hauppauge HVR-4000 card to work properly, so I've been unable to test so far.
comment:5 Changed 11 years ago by
I've compiled the BAT processing on ticket #5530 as a starting point to getting this all working.
However i've yet to get as far as testing it.
Stuart
comment:6 Changed 11 years ago by
Component: | mythtv → eit |
---|---|
Owner: | changed from Isaac Richards to Stuart Auchterlonie |
Status: | new → assigned |
comment:7 Changed 11 years ago by
(In [20048]) Refs #5603. DB Schema changes for default_authority changes.
- Removes programid's and seriesid's that don't contain a default authority
- Adjusts the size of programid & seriesid to cope with the maximum size they can be sent as
- Adds default_authority column to both dtv_multiplex and channelscan_dtv_multiplex
comment:8 Changed 11 years ago by
comment:9 Changed 11 years ago by
Status: | assigned → started |
---|
comment:10 Changed 10 years ago by
Owner: | changed from Stuart Auchterlonie to Janne Grunau |
---|---|
Status: | started → accepted |
comment:11 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
rest of this patch will be handled in #5562 especially since the patch is broken after the channelscan merge
Patch for CRIDs without authorities and NIT default authorities