Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#5612 closed defect (fixed)

bad xmltv parsing of <previously-shown>

Reported by: soren@… Owned by: stuartm
Priority: minor Milestone: unknown
Component: mythfilldatabase Version: head
Severity: low Keywords: xmltv
Cc: Ticket locked: no

Description

mythtv/programs/mythfilldatabase/xmltvparser.cpp does parse the <previously-shown> tag correctly. Current code is:

415 else if (info.tagName() == "previously-shown") 416 { 417 pginfo->previouslyshown = true; 418 419 QString prevdate = getFirstText(info); 420 pginfo->originalairdate = prevdate; 421 }

but according to the latest DTD, which states:

<!ELEMENT previously-shown EMPTY> <!ATTLIST previously-shown start CDATA #IMPLIED channel CDATA #IMPLIED >

the code should probably read:

415 else if (info.tagName() == "previously-shown") 416 { 417 pginfo->previouslyshown = true; 418 419 QString prevdate = info.attribute("start"); 420 pginfo->originalairdate = prevdate; 421 }

Regards, Søren

Change History (4)

comment:1 Changed 12 years ago by soren@…

mythtv/programs/mythfilldatabase/xmltvparser.cpp does parse the <previously-shown> tag correctly. Current code is:

415 else if (info.tagName() == "previously-shown")
416 {
417     pginfo->previouslyshown = true;
418
419     QString prevdate = getFirstText(info);
420     pginfo->originalairdate = prevdate;
421 }

but according to the latest DTD, which states:

<!ELEMENT previously-shown EMPTY>
<!ATTLIST previously-shown start CDATA #IMPLIED
channel CDATA #IMPLIED >

the code should probably read:

415 else if (info.tagName() == "previously-shown")
416 {
417     pginfo->previouslyshown = true;
418
419     QString prevdate = info.attribute("start");
420     pginfo->originalairdate = prevdate;
421 }

Regards, Søren

comment:2 Changed 12 years ago by stuartm

Status: newaccepted

comment:3 Changed 12 years ago by stuartm

Resolution: fixed
Status: acceptedclosed

(In [18395]) Fix parsing of the <previously-shown> xmltv element. Thanks to Soren, Closes #5612

comment:4 Changed 12 years ago by stuartm

(In [18396]) Backport parsing fix of the <previously-shown> xmltv element. Thanks to Soren, Refs #5612

Note: See TracTickets for help on using tickets.