Opened 11 years ago

Closed 11 years ago

#5638 closed patch (fixed)

MythConfirmationDialog focus problem

Reported by: Nigel Owned by: stuartm
Priority: minor Milestone: 0.22
Component: mythtv Version: unknown
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If this dialog is created without the Cancel button, it never responds to keyboard input (because the invisible Cancel button has focus). This works around that:

===================================================================
--- libs/libmythui/mythuitype.cpp       (revision 18170)
+++ libs/libmythui/mythuitype.cpp       (working copy)
@@ -583,7 +583,7 @@

 void MythUIType::AddFocusableChildrenToList(QMap<int, MythUIType *> &focusList)
 {
-    if (m_CanHaveFocus)
+    if (m_CanHaveFocus && m_Visible)
         focusList.insertMulti(m_focusOrder, this);

     QList<MythUIType *>::Iterator it;

but Stuart had a better way to do it (something about making nextprevwidgetfocus skip invisible widgets?)

Change History (2)

comment:1 Changed 11 years ago by Nigel

Owner: changed from Isaac Richards to stuartm
Status: newassigned

comment:2 Changed 11 years ago by stuartm

Resolution: fixed
Status: assignedclosed

(In [18186]) Ensure that the initially focused widget is also visible. Closes #5638

Note: See TracTickets for help on using tickets.